Add compile fail test for unboxed_closures feature #40047
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Hi, and thanks for the PR! One note, the test you added doesn't actually fail. You need to remove the |
|
@est31 Hi, thank you for your comment. |
|
Thanks @topecongiro! @bors: r+ delegate=est31 |
|
✌️ @est31 can now approve this pull request |
|
📌 Commit cd7b0fc has been approved by |
|
@bors rollup |
Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047
|
☔ The latest upstream changes (presumably #40091) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🔒 Merge conflict |
|
@topecongiro you'll have to rebase this pull request and resolve the created merge conflicts. PR #40031 got merged before this, and both edited the whitelist. |
|
@topecongiro note that generally, its customary to use rebase instead of merge requests. I'll r+ anyway, just remember this for your future contributions. You can just force-push if you want to change it before it gets merged this way. @bors r+ |
|
📌 Commit c4e858e has been approved by |
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
|
@est31 Sorry for bothering you. I will keep that in mind. |
|
⌛ Testing commit c4e858e with merge 29184a0... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network failure
…On Sat, Feb 25, 2017 at 11:18 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/205437965>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40047 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95BChFOPN-4hfcxxnk8cwtIO7dcs9ks5rgQsQgaJpZM4MJjSE>
.
|
|
@topecongiro can you remove that last commit? Its not required, and unneccessary clutter. |
|
FWIW the fix is to run |
|
@bors r+ |
|
📌 Commit 988be44 has been approved by |
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
Hello, this is my first contribution to rust.
Issue #39059.